Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails 6.2.2: Consolidate Gradle Plugin config to one location #408

Closed
jamesfredley opened this issue Oct 23, 2024 · 7 comments · Fixed by #424
Closed

Grails 6.2.2: Consolidate Gradle Plugin config to one location #408

jamesfredley opened this issue Oct 23, 2024 · 7 comments · Fixed by #424
Assignees

Comments

@jamesfredley
Copy link
Contributor

Currently in 3 locations, buildSrc/build.gradle, settings.gradle and build.gradle.

@matrei
Copy link
Contributor

matrei commented Nov 5, 2024

@jamesfredley Are we ready to close this issue as not planned, as it was moved to the Grails 7 board?

@codeconsole
Copy link
Contributor

codeconsole commented Nov 7, 2024

@matrei I've been thinking about this one more and I really think we should push this into Grails 6.2.2

It's a very simple change and we are only talking about modifying forgecreate-app
This requires no changes other than to forge.

The reason for this change is that it seems that most Grails users are on 5.x or less. If we are not going to support 5.x and force them to upgrade to 6.x prior to the release of 7.x, it is going to upset a lot of people and make the 7.x upgrade more difficult for them.

@codeconsole
Copy link
Contributor

This is a very simple task.

All that needs to be done is delete buildSrc/build.gradle, settings.gradle and stick this to the top of build.gradle

buildscript {
    repositories {
        maven { url "https://repo.grails.org/grails/core/" }
    }
    dependencies {
        classpath "org.grails:grails-gradle-plugin:6.2.1"
    }
}

plugins {
    id "groovy"
    id "com.github.erdi.webdriver-binaries" version "3.2"
    id "war"
    id "idea"
    id "com.bertramlabs.asset-pipeline" version "4.5.1"
    id "application"
    id "eclipse"
}
apply plugin:"org.grails.grails-web"
apply plugin:"org.grails.grails-gsp"

@matrei
Copy link
Contributor

matrei commented Nov 7, 2024

The reason for this change is that it seems that most Grails users are on 5.x or less. If we are not going to support 5.x and force them to upgrade to 6.x prior to the release of 7.x, it is going to upset a lot of people and make the 7.x upgrade more difficult for them.

Is there any reason to go through 6 to get to 7?

@codeconsole
Copy link
Contributor

@jamesfredley said on Thursday he would get it done this week and then we can release 6.2.2

The reason to get it done in 6 is for anyone that upgrades to 6 before 7 is released.

@jamesfredley
Copy link
Contributor Author

I am going to try to have a PR ready by the end of today and then we can continue the conversation against those code changes.

@jamesfredley
Copy link
Contributor Author

@jamesfredley jamesfredley linked a pull request Nov 11, 2024 that will close this issue
@jamesfredley jamesfredley moved this from In Progress to Done in Grails 6.2.2 Nov 15, 2024
@jamesfredley jamesfredley closed this as completed by moving to Done in Grails 6.2.2 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants