Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails 7: Make groovy-joint-workflow work as intended #13699

Open
jamesfredley opened this issue Sep 27, 2024 · 1 comment
Open

Grails 7: Make groovy-joint-workflow work as intended #13699

jamesfredley opened this issue Sep 27, 2024 · 1 comment

Comments

@jamesfredley
Copy link
Contributor

jamesfredley commented Sep 27, 2024

grails-core example: https://github.com/grails/grails-core/blob/7.0.x/.github/workflows/groovy-joint-workflow.yml

These changes have been completed on #13681

  • comment mavenLocal() repository from the build configuration, as it was only required for the groovy-joint-workflow GitHub workflow.
  • Updated the groovy-joint-workflow to dynamically add mavenLocal() to the build file at runtime, ensuring it is only used in the relevant workflow without affecting other builds.
  • Simplify the build by removing the use of CI_GROOVY_VERSION enviroment var and override the project property groovyVersion with a command line property assignment instead.
  • Use publishToMavenLocal instead of install when building Groovy as Grails will try to load the Groovy libraries from mavenLocal().

With these changes the groovy-joint-worflow actually uses the built Groovy libraries when building Grails.

They need to be completed on the following repos:

https://github.com/grails/grails-async
https://github.com/grails/gorm-neo4j
https://github.com/grails/gorm-mongodb
https://github.com/grails/gorm-hibernate5
https://github.com/grails/gorm-hibernate6

Already completed on:
https://github.com/grails/grails-views
https://github.com/grails/grails-testing-support
https://github.com/grails/grails-data-mapping
https://github.com/grails/grails-gsp

@jamesfredley jamesfredley converted this from a draft issue Sep 27, 2024
@jamesfredley jamesfredley changed the title Make groovy-joint-workflow work as intended Grails 7: Make groovy-joint-workflow work as intended Oct 9, 2024
@codeconsole
Copy link
Contributor

codeconsole commented Nov 13, 2024

This should all be done in a plugin and just require a single import. There is no need to add mavenLocal commented out. You can just put it in an if statement that tests to see if it is running a joint workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants