Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time part from cron expression does not respect Locales whereas hour-part is 0-23h, not AM/PM. #29

Closed
joaogac opened this issue Oct 15, 2015 · 2 comments
Closed

Time part from cron expression does not respect Locales whereas hour-part is 0-23h, not AM/PM. #29

joaogac opened this issue Oct 15, 2015 · 2 comments

Comments

@joaogac
Copy link

joaogac commented Oct 15, 2015

Time part from cron expression does not respect Locales whereas hour-part is 0-23h, not AM/PM.

Like in Spanish locale the hour-part from the cron-expression "0 15 16 ? * MON-FRI" should be "En 16:15, lunes hasta viernes", not "En 4:15 PM, lunes hasta viernes".
@joaogac joaogac mentioned this issue Oct 19, 2015
Closed
@grahamar
Copy link
Owner

grahamar commented Mar 7, 2016

I've added support for 24 hour, but it's not based on the locale as user preferences vary wildly irregardless of locale and I'd prefer it be backwards compatible first. Users can now specify 24-hour preference via the Options.

I've stripped out the Portuguese localisation from your pull request and included it in the latest.

Sorry for the delay!

@grahamar grahamar closed this as completed Mar 7, 2016
@lovepoem
Copy link
Contributor

#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lovepoem @grahamar @joaogac