Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tsdb test TestQueryHistogramFromBlocksWithCompaction #375

Open
bboreham opened this issue Dec 5, 2022 · 1 comment
Open

Fix flaky tsdb test TestQueryHistogramFromBlocksWithCompaction #375

bboreham opened this issue Dec 5, 2022 · 1 comment

Comments

@bboreham
Copy link
Contributor

bboreham commented Dec 5, 2022

Proposal

I have observed tsdb tests fail, without much description of what exactly went wrong:
https://github.com/grafana/mimir-prometheus/actions/runs/3603613156/jobs/6072026196
(There is no specific FAIL: message naming one test)

However I have noticed that tests such as TestQueryHistogramFromBlocksWithCompaction allocate several GB, so the failure could be an OOM (which is never reported by go test).
@bboreham
Copy link
Contributor Author

bboreham commented Dec 5, 2022

Believed fixed by prometheus/prometheus#11674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bboreham