Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jfrsync with async-profiler #516

Open
asodja opened this issue Nov 15, 2023 · 1 comment
Open

Add support for jfrsync with async-profiler #516

asodja opened this issue Nov 15, 2023 · 1 comment

Comments

@asodja
Copy link
Member

asodja commented Nov 15, 2023

Async-profiler supports --jfrsync CONFIG option, see README:

--jfrsync CONFIG - start Java Flight Recording with the given configuration synchronously 
with the profiler. The output .jfr file will include all regular JFR events, except that execution 
samples will be obtained from async-profiler. This option implies -o jfr.

One option is, that we add it as --profile async-profiler-jfrsync option, similarly as we have --profile async-profiler-heap. And a custom configurable --async-profiler-jfrsync CONFIG where CONFIG is passed directly to --jfrsync parameter of async-profiler.

@asodja
Copy link
Member Author

asodja commented Nov 15, 2023

Alternatively we could use --jfrsync by default. One could then configure it via --async-profiler-jfrsync CONFIG and disable it via --async-profiler-jfrsync none.

We can then also add --profile async-profiler-cpu that would measure just cpu without jfrsync, basically what does --profile async-profiler now (similar also --profile async-profiler-heap would not use jfrsync).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant