-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraalVM for JDK 24] Add support for building based on a JDK that has JEP 493 enabled #808
Comments
For the time being the steps to reproduce is to remove the
|
This will require an upstream |
Upstream MX issue: graalvm/mx#286 |
@jerboaa why does this only affect the windows builds though? |
It's not platform specific. I'm able to reproduce on Linux as well. My guess is a race condition as to why this only shows up for Windows thus far. The Windows build was done after the change to the Temurin build scripts to enable the feature, while Linux will only pick it up for |
This looks like it'll need 3 patches:
|
All of the above are now fixed and a build with JDK
|
Is your feature request related to a problem? Please describe.
GraalVM currently doesn't build if the base JDK doesn't include
jmods
. For mandrel in particular, which does no jlinking, this must be optional. For GraalVM it should link from the run-time image instead (for JDK modules), but this needs to be investigated.Describe the solution you'd like
Allow mandrel builds to succeed with/without
jmods
being present in the base JDK.Describe alternatives you've considered
Require the
jmods
to be present. Yet, it would be nice to not need this. For example for Temurin 24, JEP 493 is enabled andjmods
are not being provided (unless there is a strong reason to).Additional context
Example failing Windows build:
See: https://github.com/graalvm/mandrel/actions/runs/11944256969/job/33294889211#step:8:358
Enhancement on the Temurin side which enables JEP 493:
adoptium/temurin-build#4035
The text was updated successfully, but these errors were encountered: