Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No control over moof size while segmenting #389

Open
collin opened this issue Feb 28, 2024 · 3 comments
Open

No control over moof size while segmenting #389

collin opened this issue Feb 28, 2024 · 3 comments

Comments

@collin
Copy link

collin commented Feb 28, 2024

Currently, when segmenting a file, a large number of moof boxes are created.

For the files I've been looking at, this results in ~1MB overhead per track per minute (more or less depending on frame/samplerate).

That's probably not much of an issue when doing on-the-fly segmentation for playback, but isn't ideal when remuxing files for long term storage.

For the cases I'm thinking of there's a big advantage in being able to fragment/separate tracks on clients before uploading to servers. In particular, it would be useful to create moofs that contain an entire group of pictures.

If I were to create a patch that either:

  • allows for controlling this in the current segmentation code path
  • adds a new segmentation code path that creates larger moofs

Would that be likely to be accepted as a merge?

@DenizUgur
Copy link
Collaborator

Without seeing the actual implementation, it's hard to say if it can be merged or not. PRs are always welcome.

@collin
Copy link
Author

collin commented Nov 18, 2024

I'm not quite sure I understand that.

Is it unclear what the feature would be? What kind of implementation issues are you anticipating?

@DenizUgur
Copy link
Collaborator

It's more or less clear, I was just saying that I can't say anything for sure if it can be merged or not.

If it's a good contribution and works well without breaking existing functionality then we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants