Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery.ui.tabs.js and jquery.ui.widget.js not found while using kawwa tabs mixin #171

Open
skhatri-equens opened this issue Jul 18, 2018 · 2 comments

Comments

@skhatri-equens
Copy link

Hi,
I am currently using kawwa 2.0.6 and while upgrading to kawwa 4.0.1, I encountered an issue with the mixin tabs. The error I get is "Unable to locate asset 'classpath:META-INF/modules/tjq/vendor/ui/jquery.ui.widget.js'".
This comes from the Tabs.java class in the latest version of tapestry5-kawwa-components.
Can you please look into this issue? Please feel free to contact me.

Thanks & Regards,
Salman

@EmmanuelDemey
Copy link
Collaborator

Do you have this issue with the previous release ?
ping @adaptivui @ffacon

adaptivui added a commit that referenced this issue Aug 23, 2018
@adaptivui
Copy link
Collaborator

adaptivui commented Aug 23, 2018

Hi @skhatri-equens and @Gillespie59,

I fixed the issue on the master. There was a typo on Tabs mixins.

Actually, the mixins was refering to scripts with wrong filenames (respectively : "jquery.ui.widget", "jquery.ui.tabs" instead of "widget", "tabs"). Those scripts have been refactored and renamed in the tapestry-jquery project, which embeds JQuery code source (see before and after refactoring).

Also, Tabs class was using the @ImportJQueryUI annotation, which is deprecated and will cause issues when used for AMD modules.

Waiting for the next release, you could just inherit from Widget and import the script with the good path :

import org.apache.tapestry5.annotations.Import;
import org.got5.tapestry5.jquery.mixins.ui.Widget;

@ Import(module = {"tjq/vendor/ui/tabs"})
public class MyTabs extends Widget {
}

Nourredine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants