Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Filtering + Back button #3618

Closed
huubert opened this issue Mar 17, 2018 · 6 comments
Closed

HTML Filtering + Back button #3618

huubert opened this issue Mar 17, 2018 · 6 comments

Comments

@huubert
Copy link

huubert commented Mar 17, 2018

Describe the issue

uBlock will filter an element using a ^ filter, but after following a link to another page and then coming back to the initial one using the browser's Back button, the element won't be blocked.

One or more specific URLs where the issue occurs

https://www.reddit.com/r/popular/?geo_filter=GLOBAL

Screenshot in which the issue can be seen

https://i.imgur.com/GIAbrJu.png

Steps for anyone to reproduce the issue

  1. Add this custom filter: reddit.com##^.listingsignupbar
  2. Go to https://www.reddit.com/r/popular/?geo_filter=GLOBAL and make sure you're logged out
  3. Click any "comments" link
  4. Click the Back button
  5. The "Welcome to Reddit" bar is not blocked anymore

Your settings

https://i.imgur.com/CMLVRLc.png

  • OS/version: Windows 7 Ultimate 64-bit
  • Browser/version: Firefox Quantum 59.0.1 (64-bit)
  • uBlock Origin version: uBlock Origin v1.15.16
Your filter lists

https://i.imgur.com/2padiwp.png

Your custom filters (if any)

reddit.com##^.listingsignupbar

Edit:
This doesn't happen when using Private Browsing, so I assume it has something to do with caching.

@huubert
Copy link
Author

huubert commented Mar 17, 2018

I forgot to mention it doesn't always happen, but if I try it at least 5 times, it does.

Edit:
I tried disabling all my other addons (uMatrix and HTTPS Everywhere), completely cleaning my browser history, and restarting it, and afterwards I was able to reproduce this issue the first time around.
It definitely has something to do with the browser caching, as if I click "comments" links that I already clicked before, the issue doesn't happen. So, I guess uBlock can't modify the HTML if it's already cached by the browser?

@huubert
Copy link
Author

huubert commented Mar 19, 2018

Is anyone looking at this? I can help with anything else that would be needed to reproduce this.

@huubert
Copy link
Author

huubert commented Apr 2, 2018

Hello?

@grenzor
Copy link

grenzor commented Apr 5, 2018

I also came across this issue when using a HTML filter on a different site a week ago but I remember I couldn't reproduce it every time (happened like 1 out of 10 times from memory). Will post a site with details if I reproduce this again.

@gwarser
Copy link
Contributor

gwarser commented May 16, 2018

@huubert @grenzor can you try this dev version https://github.com/gorhill/uBlock/releases/tag/1.16.7b0 ? Should be fixed by uBlockOrigin/uBlock-issues#42

@gorhill
Copy link
Owner

gorhill commented Jun 9, 2018

Most likely same issue solved in uBlockOrigin/uBlock-issues#42.

@gorhill gorhill closed this as completed Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants