You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.
if ( pageStats && inlineScriptBlocked ) {
urls = details.scriptSources;
for ( url in urls ) {
if ( !urls.hasOwnProperty(url) ) {
continue;
}
if ( url === '{inline_script}' ) {
url = frameURL + '{inline_script}';
}
r = httpsb.filterRequest(pageURL, 'script', url);
pageStats.recordRequest('script', url, r !== false, r);
}
}
Inline script tags should always be counted, even if inlineScriptBlocked is false. inlineScriptBlocked needs to be used to filter out 3rd-party scripts to avoid counting them twice.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test case: https://news.ycombinator.com/.
Conditions:
The problem is this piece of code in
contentScriptSummaryHandler()
in https://github.com/gorhill/httpswitchboard/blob/master/js/messaging-handlers.js:Inline script tags should always be counted, even if
inlineScriptBlocked
is false.inlineScriptBlocked
needs to be used to filter out 3rd-party scripts to avoid counting them twice.The text was updated successfully, but these errors were encountered: