Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penrose orient/lock improvements #14

Open
gordonwoodhull opened this issue Oct 8, 2023 · 0 comments
Open

Penrose orient/lock improvements #14

gordonwoodhull opened this issue Oct 8, 2023 · 0 comments

Comments

@gordonwoodhull
Copy link
Owner

gordonwoodhull commented Oct 8, 2023

In the interest in getting Penrose Pipes out the door, I implemented the Orient/Lock dot using the tile transform and rotation.

This is equivalent to the cube grid implementation, where the same transforms are applied to the g.pipe, since the dot uses the same coordinate system.

This has the following weaknesses:

  • The dot is squished according to the transform, and this means it's very squished on the skinny rhombs.
  • If I extrapolate the 3D planes of all these jumbled tiles, it gives me a touch of vertigo, but it's not nearly as bad as when the pipes did were in false perspective.
  • There is no animation on the dot.
  • The dot is not perfectly centered inside its arm - ideally it should be placed on the spline at a little distance from the edge, similar to Curvy edgemarks for Penrose pipes #7.

I'm not sure, but I think rotations would have to be passed into grid.getGuideDotPosition() and polygon.get_guide_dot_position() and the polygon would need to cache a dot position per direction.

It's also worth noting that this mode makes it easy to trigger #8 wrong animation for 180º turns.

Previous discussion in #6.

@gordonwoodhull gordonwoodhull added this to the merge upstream milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant