Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize data type of ID numbers #727

Open
bennettforkner opened this issue Oct 16, 2022 · 1 comment
Open

Standardize data type of ID numbers #727

bennettforkner opened this issue Oct 16, 2022 · 1 comment
Assignees
Labels
Code Quality Changes to improve development process, cleaning up code and improving abstraction

Comments

@bennettforkner
Copy link
Contributor

bennettforkner commented Oct 16, 2022

Gordon IDs in the database are currently either a string or an integer (depending on whether they came from the TmsEPrd or MyGordon databases). I think it would be best to make them consistent before they ever get to the API. Whether this means casting them to a string or an int, I am not sure. But it would be better to have them be the same datatype so that we do not have to write all of this logic to convert them back and forth in the API/UI.

@sharonpatta sharonpatta self-assigned this Apr 4, 2023
@amos-cha
Copy link
Contributor

🎉 finally

@Centerville1 Centerville1 added the Code Quality Changes to improve development process, cleaning up code and improving abstraction label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality Changes to improve development process, cleaning up code and improving abstraction
Projects
None yet
Development

No branches or pull requests

4 participants