You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Are you open to the idea of splitting this package up in a tool package and a separate library package?
I currently use this package purely as a library and I reckon others do too. The main reason why I wish there was a separate library package is because some of the (bigger) dependencies are only required for the CLI tool.
If the library code was a separate package it would only require hollodotme/fast-cgi-client, psr/log, symfony/process, symfony/http-*.
And, although \CacheTool\CacheTool has a dependency on \Monolog\Logger, it is only used as a default logger. I think it would make more sense to use a \Psr\Log\NullLogger instance here.
Also, it would enable library consumers to upgrade to Symfony 7 (or future major versions) more easily, because consolidation/self-update is not blocking a major version upgrade in that case.
I'm happy to help with a PR. Let me know what you think!
The text was updated successfully, but these errors were encountered:
Hi @gordalina
Are you open to the idea of splitting this package up in a tool package and a separate library package?
I currently use this package purely as a library and I reckon others do too. The main reason why I wish there was a separate library package is because some of the (bigger) dependencies are only required for the CLI tool.
If the library code was a separate package it would only require hollodotme/fast-cgi-client, psr/log, symfony/process, symfony/http-*.
And, although
\CacheTool\CacheTool
has a dependency on\Monolog\Logger
, it is only used as a default logger. I think it would make more sense to use a\Psr\Log\NullLogger
instance here.Also, it would enable library consumers to upgrade to Symfony 7 (or future major versions) more easily, because consolidation/self-update is not blocking a major version upgrade in that case.
I'm happy to help with a PR. Let me know what you think!
The text was updated successfully, but these errors were encountered: