Skip to content

Commit 3a9a1bc

Browse files
committed
clean TODOs
1 parent 378e89a commit 3a9a1bc

File tree

4 files changed

+0
-8
lines changed

4 files changed

+0
-8
lines changed

samples/create_event.cc

-4
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ absl::Status WriteToFile(std::string file_path, io::cloudevents::v1::CloudEvent*
3838
}
3939

4040
absl::Status PopulateEvent(io::cloudevents::v1::CloudEvent* event){
41-
// TODO (#7): Abstract this out to a Buider with validation.
42-
4341
GetUserInput("Enter id", *event -> mutable_id());
4442
GetUserInput("Enter source", *event -> mutable_source());
4543
GetUserInput("Enter spec_version", *event -> mutable_spec_version());
@@ -49,7 +47,6 @@ absl::Status PopulateEvent(io::cloudevents::v1::CloudEvent* event){
4947
GetUserInput("Would you like to enter data (y/n)", has_data);
5048
if (has_data=="y") {
5149
std::string data_type;
52-
// TODO (#6): Support Any data
5350
GetUserInput("Enter data type (bytes/ string)", data_type);
5451
const static std::unordered_map<std::string,int> data_type_to_case{
5552
{"bytes",1},
@@ -92,7 +89,6 @@ int main(int argc, char* argv[]) {
9289
}
9390

9491
// create an event
95-
// TODO (#8): handle optional and extension attrs
9692
program_status = PopulateEvent(&event);
9793
if (!program_status.ok()) {
9894
OutputToInterface(program_status.ToString(), -1);

third_party/statusor/BUILD

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ cc_library(
1313
deps = ["@com_google_absl//absl/status"]
1414
)
1515

16-
#TODO (Michelle): fix tests
1716
cc_test(
1817
name = "statusor_test",
1918
srcs = ["statusor_test.cc"],

v1/event_format/json_formatter.cc

-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ cloudevents_absl::StatusOr<CloudEvent> JsonFormatter::Deserialize(
9898

9999
CloudEvent cloud_event;
100100

101-
// TODO (#39): Should we try to infer CE Type from serialized_data?
102101
for (auto const& member : root.getMemberNames()) {
103102
if (auto set_metadata = CloudEventsUtil::SetMetadata(member,
104103
root[member].asString(), cloud_event); !set_metadata.ok()) {

v1/util/cloud_events_util.h

-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ class CloudEventsUtil {
2020
std::string, io::cloudevents::v1::CloudEvent_CloudEventAttribute>>
2121
GetMetadata(const io::cloudevents::v1::CloudEvent& cloud_event);
2222

23-
// TODO (#44): Overload SetMetadata to accept a map of attributes
24-
2523
// set metadata without dealing with CloudEvent proto structure
2624
static absl::Status SetMetadata(const std::string& key,
2725
const std::string& val,

0 commit comments

Comments
 (0)