Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User and developer documentation for Helm json schema validation #4100

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Feb 4, 2025

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

Adds user documentation highlighting the addition of the Helm schema validation.

Updates in-place upgrades to "Beta" in the upcoming release documentation as this is for #3766#beta. There is no feature flag for in-place upgrades.

Adds developer documentation on when and how to update the Helm json schema validation file.

Also removes documentation that references fields that do not exist, and adds a field that does exist that was not documented.

Which issue(s) this PR fixes:

Working on #4093

Special notes for your reviewer:

Note that there are two commits, one with the actual changes, and one that is formatting updates only.

There will be an additional to the testing suite in an upcoming PR.

@github-actions github-actions bot added the kind/documentation Documentation for Agones label Feb 4, 2025
@igooch igooch requested a review from peterzhongyi February 4, 2025 02:09
@github-actions github-actions bot added the size/S label Feb 4, 2025
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 217ed5b1-3e04-4048-8893-d669e8ad6f3e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 688a24c0-005a-4549-9a97-3dae66f1684a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4100/head:pr_4100 && git checkout pr_4100
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-3f220a2

Updates in-place Upgrades documentation to show feature is in Beta.
There is no feature flag for in-place upgrades.
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 86e717ca-21a9-4ccc-8061-e358102cbbc8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4100/head:pr_4100 && git checkout pr_4100
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-fc24279

@peterzhongyi peterzhongyi merged commit 7a094c6 into googleforgames:main Feb 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants