Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify additional labels for controller and extension pods #4057

Merged
merged 5 commits into from
Dec 7, 2024
Merged

Add ability to specify additional labels for controller and extension pods #4057

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06a65da
Add helm values for adding labels to controller and extensions pods
R4oulDuk3 Dec 5, 2024
848cdd1
Update site documentation for helm installation of agones operator to…
R4oulDuk3 Dec 5, 2024
f7e44f4
Hide changes of controller and extensions helm values documnetation u…
R4oulDuk3 Dec 6, 2024
f00b10d
Merge branch 'main' into helm-controller-and-extension-labels
markmandel Dec 6, 2024
92ae4b9
Merge branch 'main' into helm-controller-and-extension-labels
igooch Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions install/helm/agones/templates/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ spec:
app: {{ template "agones.name" . }}
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
{{- if .Values.agones.controller.labels }}
{{- toYaml .Values.agones.controller.labels | nindent 8 }}
{{- end }}
spec:
{{- if .Values.agones.controller.topologySpreadConstraints }}
topologySpreadConstraints:
Expand Down
3 changes: 3 additions & 0 deletions install/helm/agones/templates/extensions-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ spec:
app: {{ template "agones.name" . }}
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
{{- if .Values.agones.extensions.labels }}
{{- toYaml .Values.agones.extensions.labels | nindent 8 }}
{{- end }}
spec:
{{- if .Values.agones.extensions.topologySpreadConstraints }}
topologySpreadConstraints:
Expand Down
2 changes: 2 additions & 0 deletions install/helm/agones/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ agones:
# cpu: 1
# memory: 256Mi
nodeSelector: {}
labels: {}
annotations: {}
tolerations:
- key: "agones.dev/agones-system"
Expand Down Expand Up @@ -105,6 +106,7 @@ agones:
# memory: 256Mi
nodeSelector: {}
annotations: {}
labels: {}
# Determines if the Agones extensions should operate in hostNetwork mode.
#
# This setting is necessary for certain managed Kubernetes clusters (e.g., AWS EKS) that use custom
Expand Down
2 changes: 2 additions & 0 deletions site/content/en/docs/Installation/Install Agones/helm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ The following tables lists the configurable parameters of the Agones chart and t
| `agones.controller.nodeSelector` | Controller [node labels][nodeSelector] for pod assignment | `{}` |
| `agones.controller.tolerations` | Controller [toleration][toleration] labels for pod assignment | `[]` |
| `agones.controller.affinity` | Controller [affinity][affinity] settings for pod assignment | `{}` |
| `agones.controller.labels` | [Labels][labels] added to the Agones controller pods | `{}` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we publish docs on merge, we'll need you to use a feature shortcode to hide these fields until next release.

You will likely have to make a copy of the table for each version (doing this in the middle of a table tends to render badly).

| `agones.controller.annotations` | [Annotations][annotations] added to the Agones controller pods | `{}` |
| `agones.controller.numWorkers` | Number of workers to spin per resource type | `100` |
| `agones.controller.apiServerQPS` | Maximum sustained queries per second that controller should be making against API Server | `400` |
Expand Down Expand Up @@ -368,6 +369,7 @@ The following tables lists the configurable parameters of the Agones chart and t
| `agones.extensions.nodeSelector` | Extensions [node labels][nodeSelector] for pod assignment | `{}` |
| `agones.extensions.tolerations` | Extensions [toleration][toleration] labels for pod assignment | `[]` |
| `agones.extensions.affinity` | Extensions [affinity][affinity] settings for pod assignment | `{}` |
| `agones.extensions.labels` | [Labels][labels] added to the Agones extensions pods | `{}` |
| `agones.extensions.annotations` | [Annotations][annotations] added to the Agones extensions pods | `{}` |
| `agones.extensions.numWorkers` | Number of workers to spin per resource type | `100` |
| `agones.extensions.apiServerQPS` | Maximum sustained queries per second that extensions should be making against API Server | `400` |
Expand Down
Loading