Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
gongmax committed May 13, 2024
1 parent 220c97e commit 7b5c7a3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/ISSUE_TEMPLATE/golang_version_upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Steps to upgrade Golang version:
- [ ] `find examples \( -name Dockerfile -o -name Dockerfile.windows \) -exec sed -i 's/golang:[0-9]\+\.[0-9]\+\.[0-9]\+/golang:<NEW_GOLANG_VERSION>/g' {} \;`

- [ ] Update the example images tag. At `build` directory, run:
- [ ] `make bump-image IMAGENAME=allocation-endpoint-proxy VERSION=<current-image-version>`
- [ ] `make bump-image IMAGENAME=autoscaler-webhook VERSION=<current-image-version>`
- [ ] `make bump-image IMAGENAME=crd-client VERSION=<current-image-version>`
- [ ] `make bump-image IMAGENAME=custom-controller VERSION=<current-image-version>`
Expand All @@ -23,6 +24,7 @@ Steps to upgrade Golang version:
- [ ] Create a PR for the above changes and send for review

- [ ] After the above PR is approved, **before** merging it, run the following to generate and push the new example images:
- [ ] In `examples/allocation-endpoint`, run: `make cloud-build`
- [ ] In `examples/autoscaler-webhook`, run: `make cloud-build`
- [ ] In `examples/crd-client`, run: `make cloud-build`
- [ ] In `examples/custom-controller`, run: `make cloud-build`
Expand Down

0 comments on commit 7b5c7a3

Please sign in to comment.