Transform yamllint Warnings into Errors (#3756)

* Fix Lint warnings
* Turn warnings into error

.yamllint

@@ -5,6 +5,37 @@ rules:
   truthy: disable
   line-length:
     max: 1500
+    level: error
+  trailing-spaces:
+    level: error
+  comments-indentation:
+    level: error
+  comments:
+    level: error
+  braces:
+    level: error
+  indentation:
+    level: error
+  brackets:
+    level: error
+  colons:
+    level: error
+  commas:
+    level: error
+  empty-lines:
+    level: error
+  float-values:
+    level: error
+  hyphens:
+    level: error
+  key-duplicates:
+    level: error
+  new-line-at-end-of-file:
+    level: error
+  new-lines:
+    level: error
+  octal-values:
+    level: error
 
 ignore:
   - /build/.gomod/

cloudbuild.yaml

@@ -331,23 +331,23 @@ steps:
     args:
       - --bucket=gs://$_CACHE_BUCKET
       - --key=$_CPP_SDK_BUILD_CACHE_KEY-$( checksum sdks/cpp/CMakeLists.txt )
-      - --path=sdks/cpp/.build # CPP SDK build
+      - --path=sdks/cpp/.build  # CPP SDK build
     id: cpp-sdk-build-save-cache
     waitFor:
       - build-sdks
   - name: us-docker.pkg.dev/$PROJECT_ID/ci/save_cache
     args:
       - --bucket=gs://$_CACHE_BUCKET
       - --key=$_CPP_SDK_CONFORMANCE_CACHE_KEY-$( sdks/cpp/CMakeLists.txt )
-      - --path=test/sdk/cpp/sdk # CPP conformance test build
+      - --path=test/sdk/cpp/sdk  # CPP conformance test build
     id: cpp-sdk-conformance-save-cache
     waitFor:
       - sdk-conformance
   - name: us-docker.pkg.dev/$PROJECT_ID/ci/save_cache
     args:
       - --bucket=gs://$_CACHE_BUCKET
       - --key=$_RUST_SDK_BUILD_CACHE_KEY-$( checksum test/sdk/rust/Cargo.toml )
-      - --path=test/sdk/rust/.cargo # Rust conformance test build
+      - --path=test/sdk/rust/.cargo  # Rust conformance test build
       - --path=test/sdk/rust/.cargo-targets
       - --no-clobber
     id: rust-build-save-cache
@@ -357,7 +357,7 @@ steps:
     args:
       - --bucket=gs://$_CACHE_BUCKET
       - --key=$_HTMLTEST_CACHE_KEY
-      - --path=site/tmp # htmltest URL checks
+      - --path=site/tmp  # htmltest URL checks
     id: htmltest-save-cache
     waitFor:
       - tests

examples/gameserverallocation.yaml

@@ -85,6 +85,7 @@ spec:
       mode: deathmatch
     annotations:
       map: garden22
+  # yamllint disable rule:comments-indentation rule:line-length
   # [Stage: Alpha]
   # [FeatureFlag:CountsAndLists]
   # `Priorities` configuration alters the order in which `GameServers` are searched for matches to the configured `selectors`.