Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For color fonts, make GID 1 the .null glyph #880

Closed
madig opened this issue Oct 11, 2024 · 6 comments · Fixed by #881
Closed

For color fonts, make GID 1 the .null glyph #880

madig opened this issue Oct 11, 2024 · 6 comments · Fixed by #881
Assignees

Comments

@madig
Copy link
Collaborator

madig commented Oct 11, 2024

Seems to be a required quirk in Windows, see djrrb/Bungee#53.

@anthrotype
Copy link
Member

it doesn't have to be the legacy .null glyph , it just needs to be empty. nanoemoji would put the space at gid1.
gftools even has a fixer script that reorders the glyphs such that gid1 is an empty glyph.
People can already define their public.glyphOrder as they please so I don't think ufo2ft needs to do anything.

@anthrotype
Copy link
Member

also see googlefonts/gftools#609 and MicrosoftDocs/typography-issues#346

@khaledhosny
Copy link
Collaborator

GlyphsApp always makes space glyph id 1 (unless you really really ask it not to), may be we should do the same by default for all fonts.

@anthrotype
Copy link
Member

ok.. PR?

@khaledhosny khaledhosny self-assigned this Oct 11, 2024
khaledhosny added a commit that referenced this issue Oct 12, 2024
@anthrotype
Copy link
Member

@khaledhosny so this fixes it for DS+ufo projects that don't explicitly set their public.glyphOrder. But a lot of inputs to ufo2ft are actually DS+ufos that are in turn generated from glyphsLib, and the latter always sets a public.glyphOrder, and AFAIK it doesn't do anything special for 'space'. I suppose it should?

@khaledhosny
Copy link
Collaborator

Yes, I’ll do the equivalent of this change in glyphsLib shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants