Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor propagation for ligatures is broken somtimes #313

Open
khaledhosny opened this issue Feb 10, 2018 · 4 comments
Open

Anchor propagation for ligatures is broken somtimes #313

khaledhosny opened this issue Feb 10, 2018 · 4 comments

Comments

@khaledhosny
Copy link
Collaborator

khaledhosny commented Feb 10, 2018

Consider the font JosefinSans.glyphs; the glyph f_ij has two components f and ij and it ends up with the anchors bottom, bottom_1, bottom_2, ogonek, top, top_1, and top_2, but the top and bottom anchors make no sense here AFAIK. Even worse, the glyph f_f_ij ends with different set of anchors (name names but different positions) on each run.

Furthermore, I think the number of ligature anchors need to reflect the number of characters that make up the ligature not the number of components which may or may not be unrelated. i.e. if we have sub f ij by f_ij; then there should be two ligature anchors regardless of how many components f_ij glyph has.

khaledhosny added a commit to aliftype/reem-kufi that referenced this issue Feb 10, 2018
@behdad
Copy link
Contributor

behdad commented Feb 10, 2018

Furthermore, I think the number of ligature anchors need to reflect the number of characters that make up the ligature not the number of components which may or may not be unrelated. i.e. if we have sub f ij by f_ij; then there should be two ligature anchors regardless of how many components f_ij glyph has.

Actually the way OpenType is implemented in Uniscribe and HarfBuzz, if ij was itself a ligature of two components, the f_ij will get three components.

@khaledhosny
Copy link
Collaborator Author

I stand corrected then.

@moyogo
Copy link
Collaborator

moyogo commented Feb 11, 2018

Well, f_ij is, according to AGLFN, the ligature between the two characters f and ij U+0133. That is also what the font does in the dlig sub f ij by f_ij;.

@anthrotype
Copy link
Member

looks like a duplicate of #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants