Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark glyph width zeroing doesn't use unicode values when finding glyphInfo #1059

Open
cmyr opened this issue Jan 23, 2025 · 0 comments · May be fixed by #1060
Open

mark glyph width zeroing doesn't use unicode values when finding glyphInfo #1059

cmyr opened this issue Jan 23, 2025 · 0 comments · May be fixed by #1060

Comments

@cmyr
Copy link
Member

cmyr commented Jan 23, 2025

When converting a glyph from glyphs to ufo, we zero the widths of non-spacing marks. The logic here involves finding the category and subcategory if the glyph by looking it up in the bundled GlyphData; but this lookup only uses the user-assigned glyph name, which can be arbitrary.

Elsewhere when we fetch this data (such as when building public.openTypeCategories we use the name as well as the unicode values; we should be doing the same during conversion.

(I have a patch for this I'll push in a moment, just wanted an issue to reference)

@cmyr cmyr linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant