From 5cef7c4768b4030ec370428f369ad6cae74766d4 Mon Sep 17 00:00:00 2001 From: Simon Cozens Date: Mon, 18 Mar 2024 13:21:52 +0000 Subject: [PATCH 1/2] Run black and pylint --- .github/workflows/test.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0b88809bb..823d5fc41 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -29,7 +29,11 @@ jobs: - name: Install packages run: | pip install '.[qa]' - pip install mypy pytest + pip install mypy pytest black pylint + - name: Lint checks + run: | + black . --check --diff --color Lib tests + pylint Lib - name: Run Tests env: DEV_FAMILY_DOWNLOAD: ${{ secrets.DEV_FAMILY_DOWNLOAD }} From e3d8e29e39fd6b74e9b7ac3f0950a64814499714 Mon Sep 17 00:00:00 2001 From: Simon Cozens Date: Mon, 18 Mar 2024 13:22:00 +0000 Subject: [PATCH 2/2] A reasonable set of pylint settings to get us going --- pyproject.toml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/pyproject.toml b/pyproject.toml index f8ae4b436..fa6148d58 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -165,3 +165,16 @@ where = ["Lib"] [tool.setuptools_scm] write_to = "Lib/gftools/_version.py" + +[tool.pylint.'MESSAGES CONTROL'] +max-line-length = 120 +disable = [ + "R", # Disable all recommendations for now + "missing-class-docstring", + "missing-function-docstring", + "missing-module-docstring", + "duplicate-code", + "protected-access", + "attribute-defined-outside-init", + "invalid-name", # For now, we would like to fix these +] \ No newline at end of file