Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve function signatures of registerAction and registerActionCallbacks #1929

Open
justvanrossum opened this issue Jan 10, 2025 · 0 comments
Assignees

Comments

@justvanrossum
Copy link
Collaborator

justvanrossum commented Jan 10, 2025

These currently take three positional arguments for three callbacks, the latter two being optional. It would be better if we pass a "callbacks" object, like this:

    registerActionCallbacks(actionIdentifier, { callback: ..., enabled: ..., title: ... });

This should be easier to remember than the argument order.

(This will have to wait until after #1925 is done.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants