Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider size in crater #972

Open
rsheeter opened this issue Sep 25, 2024 · 2 comments
Open

Consider size in crater #972

rsheeter opened this issue Sep 25, 2024 · 2 comments
Assignees
@cmyr
Labels
enhancement New feature or request
Milestone
100 families pass...

Comments

@rsheeter
Copy link
Contributor

@garretrieger suggested adding size to https://googlefonts.github.io/fontc_crater/, e.g. if ours is dramatically larger (say more than +10%?) deem it a fail, based on past experience with HarfBuzz vs FontTools subsetting comparisons
@rsheeter
Copy link
Contributor Author

Possibly on a table by table basis as one table being more compact shouldn't hide another table being bigger

@rsheeter rsheeter added the enhancement New feature or request label Sep 25, 2024
@cmyr
Copy link
Member

cmyr commented Sep 30, 2024

I agree this is something it would be nice to know, and it's maybe mostly a question of UX? A first step would be to add some size comparison functionality to ttx_diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmyr cmyr

Labels
enhancement New feature or request
Projects
None yet
Milestone
100 families pass ttx_diff in default...
Development

No branches or pull requests
2 participants
@cmyr @rsheeter