Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_stat: don't include weight AxisValues if there is no weight axis in the fvar table #99

Open
m4rc1e opened this issue Dec 1, 2022 · 2 comments

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Dec 1, 2022

Describe the issue
In google/fonts#5652 fontbakery is complaining that the font is missing wght STAT axisvalues. However, the font doesn't have a wght axis so this shouldn't be an error.

cc @RosaWagner

@RosaWagner
Copy link
Contributor

RosaWagner commented Oct 19, 2023

After thinking about it, we still could have 400 in the stat table. Even with no weight axis, we still have a weight=400 so it makes sense. But the checks also raises a FAIL because 700 in not linked to 400, although 700 really do not exists.

to set it up; no axis in the source file, but a weight axis declared in the config.yaml file. Like we would do for the italic.

@vv-monsalve
Copy link
Contributor

But the checks also raises a FAIL because 700 in not linked to 400, although 700 really do not exists

This is the most common case of falsy Fail for this check. It's been reported for all the Playwrite families.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants