Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify is_parametric in axis metadata #173

Open
nathan-williams opened this issue May 6, 2024 · 2 comments
Open

Specify is_parametric in axis metadata #173

nathan-williams opened this issue May 6, 2024 · 2 comments
Labels
--review-axis Revision of a registered axis

Comments

@nathan-williams
Copy link

Describe the issue

The pipeline is prepared to accept axis metadata with is_parametric.

optional bool is_parametric

We should add the corresponding field to the upstream proto definition and populate the field for all parametric axes. There are currently 9 as I understand it: x_opaque, x_transparent, x_transparent_figures, y_opaque, y_transparent_ascender, y_transparent_descender, y_transparent_figures, y_transparent_lowercase, and y_transparent_uppercase.

@nathan-williams nathan-williams added the --review-axis Revision of a registered axis label May 6, 2024
@vv-monsalve
Copy link
Contributor

Hi, @nathan-williams. Could you help us gain more context about this new field? For example, what is the purpose and effect of adding it?

@nathan-williams
Copy link
Author

The only known use today is to inform axis ordering. For example, in a list of axes, we would want to show GRAD before XOPQ. This property has existed on our side for quite a while, but we realized just recently that the property was not being populated.

Let me know if I can support in identifying the parametric axes. They stand out pretty well among the existing axes if you know what to look for (i.e. axes with tags that match /(X|Y).../ more or less).

@davelab6 may be able to provide more insight into the definition of a parametric axis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--review-axis Revision of a registered axis
Projects
None yet
Development

No branches or pull requests

2 participants