Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Support configuration of the xmppAddress #45

Open
froodian opened this issue Sep 20, 2016 · 1 comment
Open

Support configuration of the xmppAddress #45

froodian opened this issue Sep 20, 2016 · 1 comment

Comments

@froodian
Copy link

froodian commented Sep 20, 2016 •
edited
Loading

xmppAddress is currently defined as a constant (https://sourcegraph.com/github.com/google/go-gcm/-/blob/gcm.go#L42) - this prevents clients from specifying the pre-prod server at gcm-preprod.googleapis.com:5236, or (more importantly for my use-case) connecting to the newer fcm-xmpp.googleapis.com:5235
@froodian
Copy link
Author

Note that to work with FCM, this requires separating xmppHost from xmppAddress as well (as the xmppUser should still be senderId + "@gcm.googleapis.com", per https://firebase.google.com/docs/cloud-messaging/server)

froodian pushed a commit to froodian/go-gcm that referenced this issue Sep 20, 2016
Fixes googlearchive#45 - Support configuration of the xmppAddress
74b5b49
froodian pushed a commit to froodian/go-gcm that referenced this issue Sep 21, 2016
Merge pull request #1 from froodian/45
899691f 
Fixes googlearchive#45 - Support configuration of the xmppAddress
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@froodian