Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Makes dynamic sizing of core-dropdown possible #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rezonant
Copy link

@rezonant rezonant commented Nov 3, 2014

Currently, the size of the dropdown is set in stone the first time the user views it. If the contents of the dropdown change in content or size later, the dropdown will not adjust. This is because measure() does not remove the width/height which is set from the results of measure() in previous runs, thus the size is always the "same".

In addition to this PR, I have pushed a fork of the current production tag (0.4.2) along with a patch onto:
https://github.com/rezonant/core-dropdown/tree/0.4.2_measurepatch.

Reproduction

  1. core-dropdown is opened
  2. core-dropdown may be closed or left open
  3. content changes, causing a new size
  4. core-dropdown's overlay size is now incorrect until the widget is reloaded

@ebidel
Copy link

ebidel commented Nov 4, 2014

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

@ebidel ebidel added cla: no and removed cla: yes labels Nov 4, 2014
@rezonant
Copy link
Author

rezonant commented Nov 4, 2014

Hello Eric, I had already signed the CLA. Should be on file with my github username.

@ebidel ebidel added cla: yes and removed cla: no labels Nov 4, 2014
@ebidel
Copy link

ebidel commented Nov 4, 2014

Verified. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants