Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Fix missing } after function body in FF #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing } after function body in FF #20

wants to merge 1 commit into from

Conversation

svenpopping
Copy link

The <html> and <body> tags in the comments will cause a SyntaxError: missing } after function body in FF 32.0, changing those into html and body will solve the problem.

The <html> and <body> tags will cause a ```SyntaxError: missing } after function body``` in FF 32.0, changing those to html and body will solve the problem.
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@svenpopping
Copy link
Author

I signed the CLA.

On 20 Jan 2015, at 00:56, googlebot [email protected] wrote:

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/ https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA https://cla.developers.google.com/clas or see this help article on setting the email on your git commits https://help.github.com/articles/setting-your-email-in-git/.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.


Reply to this email directly or view it on GitHub #20 (comment).

@googlebot
Copy link

CLAs look good, thanks!

@addyosmani
Copy link
Contributor

Testing in FF stable and nightly I've been unable to verify that this is causing breakage. Is anyone else experiencing this?

@ShadowBan
Copy link

I can confirm that I am having this issue with Firefox version 36.0 on Ubuntu 14.10. I checked in Chrome Version 40.0.2214.115 (64-bit) on Ubuntu 14.10 and this issue does not present itself.

I edited the two lines included in this pull request and it does indeed seem to solve the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants