Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: capture and re-throw more clear error when sfl4j not in classpath but logging enabled. #3649

Open
zhumin8 opened this issue Feb 20, 2025 · 0 comments
Open

Logging: capture and re-throw more clear error when sfl4j not in classpath but logging enabled. #3649

zhumin8 opened this issue Feb 20, 2025 · 0 comments
Labels
api: logging Issues related to the Cloud Logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Feb 20, 2025 •
edited
Loading

context: #3403 (comment)

For scenario where customer app does not have logging dependency (SLF4J), but turns on logging via env variable, logging would fail. Currently, this would throw ClassNotFoundException.

For better customer experience, we can capture this and re-throw with more clear error message to communicate to customer.

Note: if change, this applies to both Gax and Auth. Need code changes in both repos.
@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Feb 20, 2025
@zhumin8 zhumin8 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed api: logging Issues related to the Cloud Logging API. labels Feb 20, 2025
@zhumin8 zhumin8 mentioned this issue Feb 20, 2025
Open
@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhumin8