Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add showcase testing for logging on stream cases #3645

Open
zhumin8 opened this issue Feb 19, 2025 · 0 comments
Open

test: add showcase testing for logging on stream cases #3645

zhumin8 opened this issue Feb 19, 2025 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Feb 19, 2025

Basic logging testing are included in #3403 for unary calls.
Test cases are missing for server side streaming, client side streaming and bidi-streaming.

We need more test coverage for logging behaviors on other type of calls beside unary calls.

Also, consider refactor showcase test to not depend on a TestAppender, but rather capture log outputs from console. This will allow logging implementation classes like GrpcLoggingInterceptor to be not public.

@zhumin8 zhumin8 added type: process A process-related concern. May include testing, release, or the like. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

1 participant