Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old OpenTelemetry Semantic Convention dependency from third_party_dependencies #3598

Open
michaelpri10 opened this issue Jan 30, 2025 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@michaelpri10
Copy link
Contributor

In #3402, the OpenTelemetry Semantic Convention dependency is being updated from io.opentelemetry:opentelemetry-semconv to io.opentelemetry.semconv:opentelemetry-semconv. However, the old package is being kept until the Pub/Sub Java client no longer depends on it. This is to track removing the old dependency once the Pub/Sub dependency is updated.

@lqiu96 lqiu96 added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 30, 2025
@suztomo
Copy link
Member

suztomo commented Feb 18, 2025

Memo: The google-cloud-spanner-executor module in the java-spanner repository also transitively depends on 49ac09d

Error:  Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce) on project google-cloud-spanner-executor: 
Error:  Rule 2: org.apache.maven.enforcer.rules.dependency.RequireUpperBoundDeps failed with message:
Error:  Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Error:  Require upper bound dependencies error for io.opentelemetry.semconv:opentelemetry-semconv:1.26.0-alpha [runtime] paths to dependency are:
Error:  +-com.google.cloud:google-cloud-spanner-executor:6.86.1-SNAPSHOT
Error:    +-com.google.cloud.opentelemetry:exporter-trace:0.33.0
Error:      +-io.opentelemetry.semconv:opentelemetry-semconv:1.26.0-alpha [runtime] (managed) <-- io.opentelemetry.semconv:opentelemetry-semconv:1.27.0-alpha [runtime]
Error:  ]

Because this is a new coordinates (io.opentelemetry.semconv group ID), the problem of java-spanner will be fixed after 49ac09d is released, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

3 participants