Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo: Avoid creating empty PR #2384

Open
gvillo opened this issue Sep 23, 2024 · 1 comment
Open

Monorepo: Avoid creating empty PR #2384

gvillo opened this issue Sep 23, 2024 · 1 comment
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@gvillo
Copy link

gvillo commented Sep 23, 2024

Is your feature request related to a problem? Please describe.
Kinda! We have a monorepo and it's creating a PR for the root (I guess) named chore: release main with 0 files on it.

I have the following release-please-config.json

{
	"include-component-in-tag": true,
	"include-v-in-tag": false,
	"tag-separator": "@",
	"separate-pull-requests": true,
	"pull-request-footer": "Al mergear esto va a deployar a PROD!",
	"packages": {
		"apps/web1": {
			"component": "@app/web1",
			"release-type": "node"
		},
		"apps/web2": {
			"component": "@app/web2",
			"release-type": "node"
		},
		"packages/sdk-js": {
			"component": "@pkg/sdk",
			"release-type": "node"
		}
	},
	"plugins": [
		{
			"type": "node-workspace",
			"updatePeerDependencies": true
		}
	],
	"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}

I don't understand the reason that it's creating that empty PR if there is no "." packages in release-please-config.json file.

A clear and concise description of what you want to happen.

If there is no "." entry declared, it should create a PR for the root package.json.

Add any other context or screenshots about the feature request here.
image

@gvillo gvillo added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 23, 2024
@treyturner
Copy link

I'm new to this action and spent way too much time trying to figure out what I was doing wrong to cause this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants