Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Release-as should always take effect when merged to main #2349

Open
wheresrhys opened this issue Aug 3, 2024 · 0 comments
Open

Feat: Release-as should always take effect when merged to main #2349

wheresrhys opened this issue Aug 3, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wheresrhys
Copy link

wheresrhys commented Aug 3, 2024

Is your feature request related to a problem? Please describe.
Most of my monorepo's build config lives at the root level. If I make a change here that impacts a package no committed files within the package's root change. Therefore release please does not create a release for the package. So far this makes sense: how could release please know.

I added "release-as": "1.2.3" to the package override in release-please-config.json to - as I expected - force the package to be released when my PR was merged. To my dismay, this only forces a release at that version number if there were committed changes within the package directory.

There does not appear to be away to force a release of a package in a monorepo unless there are changes to committed files within the package directory. This does not support sharing build tooling between packages very well.

Describe the solution you'd like
Either

  1. release-as, when added to a package config, forces a release on the next push to main
  2. An additional option, forceReleaseWithoutRelevantCommit: true (or similar) to force a package release without any commits in the relevant directory

Additional context
Relevant PR wheresrhys/fetch-mock#771

@wheresrhys wheresrhys added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 3, 2024
@wheresrhys wheresrhys changed the title Feat: Release-as shoudl always take effect when merged to main Feat: Release-as should always take effect when merged to main Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant