Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show deprecation warning when read_session passed to ReadRowsStream.rows, ReadRowsStream.to_arrow, ReadRowsStream.to_dataframe #229

Open
tswast opened this issue Jul 8, 2021 · 2 comments
Open

show deprecation warning when read_session passed to ReadRowsStream.rows, ReadRowsStream.to_arrow, ReadRowsStream.to_dataframe #229

tswast opened this issue Jul 8, 2021 · 2 comments
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Jul 8, 2021

Follow-up to #228, which quietly deprecates read_session.

I want to wait until google-cloud-bigquery doesn't rely on this behavior before we more loudly deprecate it.
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Jul 8, 2021
@tswast tswast mentioned this issue Jul 8, 2021
Closed
@tswast
Copy link
Contributor Author

tswast commented Jul 8, 2021

Blocked by googleapis/python-bigquery#742

@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Jul 8, 2021
@tswast tswast mentioned this issue Jul 9, 2021
Merged
4 tasks
@meredithslota
Copy link

Blocker was fixed in googleapis/python-bigquery#748, so this is unblocked.

@meredithslota meredithslota added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. next major: breaking change this is a change that we should wait to bundle into the next major version and removed type: process A process-related concern. May include testing, release, or the like. labels Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tswast @meredithslota