-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(debugging): implement x-goog-spanner-request-id propagation per request #2205
Open
odeke-em
wants to merge
9
commits into
googleapis:main
Choose a base branch
from
odeke-em:x-goog-spanner-request-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: spanner
Issues related to the googleapis/nodejs-spanner API.
labels
Dec 21, 2024
odeke-em
force-pushed
the
x-goog-spanner-request-id
branch
3 times, most recently
from
December 21, 2024 16:13
1f5c031
to
85f6d7a
Compare
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: m
Pull request size is medium.
labels
Dec 21, 2024
odeke-em
force-pushed
the
x-goog-spanner-request-id
branch
2 times, most recently
from
December 22, 2024 12:40
323edc3
to
fc4a2de
Compare
6 tasks
…request Implements propagation of the x-goog-spanner-request-id that'll be propagated for every call. Once an error has been encountered, that error will have `.requestId` set. Fixes googleapis#2200
odeke-em
force-pushed
the
x-goog-spanner-request-id
branch
2 times, most recently
from
December 24, 2024 19:05
210bbc1
to
b6e7308
Compare
product-auto-label
bot
added
size: xl
Pull request size is extra large.
and removed
size: l
Pull request size is large.
labels
Dec 24, 2024
odeke-em
force-pushed
the
x-goog-spanner-request-id
branch
from
December 24, 2024 19:07
b6e7308
to
c27ba41
Compare
odeke-em
force-pushed
the
x-goog-spanner-request-id
branch
from
December 24, 2024 19:08
c27ba41
to
12efa68
Compare
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: xl
Pull request size is extra large.
labels
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/nodejs-spanner API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements propagation of the x-goog-spanner-request-id that'll be propagated for every call. Once an error has been encountered, that error will have
.requestId
set.Fixes #2200