Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unary pull subscribers ack ID batches can exceed Acknowledge size limit #344

Open
matt-kwong opened this issue Aug 7, 2024 · 0 comments
Assignees

Comments

@matt-kwong
Copy link
Collaborator

AckBatchingSubscriber periodically flushes pending ack IDs in a single AcknowledgeRequest, which can exceed the 512 KB size limit for Acknowledge RPCs. This code is here.

To avoid Acknowledge RPCs failing due to exceeding the size limit, we should split large batches of ack IDs into multiple Acknowledge RPCs. One way to fix this is adopting the Cloud Pub/Sub client library behavior of including at most 100 ack IDs per Acknowledge RPC.

@matt-kwong matt-kwong self-assigned this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant