Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated commitRecord(org.apache.kafka.connect.source.SourceRecord) found in CPS source connector #201

Open
anguillanneuf opened this issue Nov 18, 2022 · 0 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@anguillanneuf
Copy link
Collaborator

Warning:

/java-pubsub-group-kafka-connector/src/main/java/com/google/pubsub/kafka/source/CloudPubSubSourceTask.java:[372,15]
commitRecord(org.apache.kafka.connect.source.SourceRecord) in org.apache.kafka.connect.source.SourceTask has been
deprecated

RecordMetadata has been added to the method signature for commitRecord:

            @Override
            @SuppressWarnings("deprecation")
            public void commitRecord(SourceRecord record) throws InterruptedException {
                block.maybeBlockOn(SOURCE_TASK_COMMIT_RECORD);
                super.commitRecord(record);
            }

            @Override
            public void commitRecord(SourceRecord record, RecordMetadata metadata) throws InterruptedException {
                block.maybeBlockOn(SOURCE_TASK_COMMIT_RECORD_WITH_METADATA);
                super.commitRecord(record, metadata);
            }
@anguillanneuf anguillanneuf changed the title Update deprecated org.apache.kafka.connect.source.SourceTask found in CPS source connector Update deprecated ommitRecord(org.apache.kafka.connect.source.SourceRecord) found in CPS source connector Nov 18, 2022
@anguillanneuf anguillanneuf changed the title Update deprecated ommitRecord(org.apache.kafka.connect.source.SourceRecord) found in CPS source connector Update deprecated commitRecord(org.apache.kafka.connect.source.SourceRecord) found in CPS source connector Nov 18, 2022
@anguillanneuf anguillanneuf added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

3 participants