Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must import wkt crate if any message is present #846

Closed
Tracked by #825
coryan opened this issue Jan 25, 2025 · 0 comments · Fixed by #847
Closed
Tracked by #825

Must import wkt crate if any message is present #846

coryan opened this issue Jan 25, 2025 · 0 comments · Fixed by #847
Assignees
@coryan
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. sidekick Issues related to the code generator type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: process A process-related concern. May include testing, release, or the like.

Comments

@coryan
Copy link
Contributor

coryan commented Jan 25, 2025 •
edited
Loading

We need to import the wkt crate to define the wkt::message::Message trait. Otherwise we get errors:

error[E0433]: failed to resolve: use of undeclared crate or module `wkt`
  --> src/generated/cloud/language/v2/src/model.rs:85:6
   |
85 | impl wkt::message::Message for Document {
   |      ^^^ use of undeclared crate or module `wkt`

Note that one of the golden files already has this problem. It uses the crate here:

google-cloud-rust/generator/testdata/rust/protobuf/golden/type/src/model.rs

Line 117 in 25149ad

impl wkt::message::Message for Expr {

But it is missing here:

google-cloud-rust/generator/testdata/rust/protobuf/golden/type/src/model.rs

Lines 20 to 21 in 25149ad

#![no_implicit_prelude]
extern crate std;

@coryan coryan mentioned this issue Jan 25, 2025
Open
1 task
@coryan coryan added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: process A process-related concern. May include testing, release, or the like. priority: p3 Desirable enhancement or fix. May not be included in next release. sidekick Issues related to the code generator labels Jan 25, 2025
@coryan coryan mentioned this issue Jan 25, 2025
Merged
@coryan coryan self-assigned this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. sidekick Issues related to the code generator type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: configure sidekick to always use wkt coryan/google-cloud-rust
1 participant
@coryan