fix: [backupdr] finalize fixing typings for headers in generator #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
feat: Add backupplan proto feat: Add backupplanassociation proto feat: Add backupvault_ba proto feat: Add backupvault_gce proto docs: A comment for field `oauth2_client_id` in message `.google.cloud.backupdr.v1.ManagementServer` is changed docs: A comment for field `parent` in message `.google.cloud.backupdr.v1.ListManagementServersRequest` is changed docs: A comment for field `management_servers` in message `.google.cloud.backupdr.v1.ListManagementServersResponse` is changed docs: A comment for field `name` in message `.google.cloud.backupdr.v1.GetManagementServerRequest` is changed docs: A comment for field `parent` in message `.google.cloud.backupdr.v1.CreateManagementServerRequest` is changed docs: A comment for field `requested_cancellation` in message `.google.cloud.backupdr.v1.OperationMetadata` is changed PiperOrigin-RevId: 678800741 Source-Link: googleapis/googleapis@d36e288 Source-Link: googleapis/googleapis-gen@fba9d22 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJmYmE5ZDIyNWI0M2RjZjczNjEwMDY0OTE4MTA0ODVjZGYxYjU3Y2RiIn0=
|
/gcbrun |
gcf-owl-bot
bot
requested review from
yoshi-approver and
a team
as code owners
|
/gcbrun |
…/github.com/googleapis/google-cloud-node into owl-bot-copy-packages-google-cloud-backupdr
|
/gcbrun |
|
Note to reviewers: A change in this PR is being evaluated for rollback. I can't add |
danielbankhead
approved these changes
Sep 27, 2024
|
/gcbrun |
danielbankhead
added
the
do not merge
fix!: Remove visibility of unneeded InitiateBackup RPC fix!: Remove visibility of unneeded AbandonBackup RPC fix!: Remove visibility of unneeded FinalizeBackup RPC fix!: Remove visibility of unneeded RemoveDataSource RPC fix!: Remove visibility of unneeded SetInternalStatus RPC PiperOrigin-RevId: 683196317 Source-Link: googleapis/googleapis@c532f35 Source-Link: googleapis/googleapis-gen@fd43f57 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJmZDQzZjU3MzNiMDAyMzU4ZmE2Nzk2MjNmNjA5OWFhZmI2NjYwYzhlIn0=
gcf-owl-bot
bot
changed the title
|
/gcbrun |
|
/gcbrun |
feat: specify retry configuration PiperOrigin-RevId: 712493958 Source-Link: googleapis/googleapis@29aea41 Source-Link: googleapis/googleapis-gen@04bcbab Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiIwNGJjYmFiNDUwNTk4OWU5ODRiMTQwM2Q0MzhmZmZjMDMxMjE0NGFmIn0=
gcf-owl-bot
bot
changed the title
|
/gcbrun |
|
/gcbrun |
feat: Update field behavior of `networks` field in message `ManagementServer` to `OPTIONAL` feat: add enum to Backup Vault Access Restriction field feat: `ignore_backup_plan_references` added to the DeleteBackupVaultRequest fix!: Update field behavior of `resource_type` field in message `BackupPlanAssociation` to `REQUIRED` docs: A comment for field `networks` in message `.google.cloud.backupdr.v1.ManagementServer` is changed docs: A comment for field `requested_cancellation` in message `.google.cloud.backupdr.v1.OperationMetadata` is changed docs: A comment for field `resource_type` in message `.google.cloud.backupdr.v1.BackupPlan` is changed docs: A comment for field `backup_retention_days` in message `.google.cloud.backupdr.v1.BackupRule` is changed docs: A comment for field `resource_type` in message `.google.cloud.backupdr.v1.BackupPlanAssociation` is changed docs: A comment for field `data_source` in message `.google.cloud.backupdr.v1.BackupPlanAssociation` is changed docs: A comment for field `rule_id` in message `.google.cloud.backupdr.v1.RuleConfigInfo` is changed docs: A comment for field `last_backup_error` in message `.google.cloud.backupdr.v1.RuleConfigInfo` is changed docs: A comment for enum value `ACCESS_RESTRICTION_UNSPECIFIED` in enum `AccessRestriction` is changed docs: A comment for field `uid` in message `.google.cloud.backupdr.v1.BackupVault` is changed docs: A comment for field `access_restriction` in message `.google.cloud.backupdr.v1.BackupVault` is changed PiperOrigin-RevId: 713528070 Source-Link: googleapis/googleapis@8cd8706 Source-Link: googleapis/googleapis-gen@a5c65fa Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJhNWM2NWZhY2ViZThkNTUyM2FkZTYwZmE1NTA2YmM4YzM1ZGFkODY4In0=
gcf-owl-bot
bot
changed the title
|
/gcbrun |
|
/gcbrun |
fix: add x-goog-request params to headers for LRO-polling methods fix: remove extra protos in ESM & capture ESM in headers docs: update comments for a Nodejs stream object PiperOrigin-RevId: 721038181 Source-Link: googleapis/googleapis@331a41a Source-Link: googleapis/googleapis-gen@e81b4c5 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJlODFiNGM1YjUyMDg4OTVmNjYzYTI0MDQ4NjE1YTU5ZDU2MzZmNDE1In0=
gcf-owl-bot
bot
changed the title
|
/gcbrun |
|
/gcbrun |
PiperOrigin-RevId: 723181578 Source-Link: googleapis/googleapis@c7b69f4 Source-Link: googleapis/googleapis-gen@d1bc1ac Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJkMWJjMWFjZDc0Mjk2NDIyYTVjYjZlMGM0MDE2YzhjNDhlOTk4NTM4In0=
gcf-owl-bot
bot
changed the title
|
/gcbrun |
|
/gcbrun |
PiperOrigin-RevId: 723563760 Source-Link: googleapis/googleapis@2f843e2 Source-Link: googleapis/googleapis-gen@cd0f9c6 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJjZDBmOWM2ZmUxZGQ3N2M1NTJlZjc2NmU2MDQ3ZjhkY2ZkM2JjYzJlIn0=
gcf-owl-bot
bot
changed the title
|
/gcbrun |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 723563760
Source-Link: googleapis/googleapis@2f843e2
Source-Link: https://github.com/googleapis/googleapis-gen/commit/cd0f9c6fe1dd77c552ef766e6047f8dcfd3bcc2e
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJjZDBmOWM2ZmUxZGQ3N2M1NTJlZjc2NmU2MDQ3ZjhkY2ZkM2JjYzJlIn0=
BEGIN_NESTED_COMMIT
fix: [backupdr] fix typings for headers in generator
PiperOrigin-RevId: 723181578
Source-Link: googleapis/googleapis@c7b69f4
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d1bc1acd74296422a5cb6e0c4016c8c48e998538
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJkMWJjMWFjZDc0Mjk2NDIyYTVjYjZlMGM0MDE2YzhjNDhlOTk4NTM4In0=
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [backupdr] paging changes for bigquery
fix: add x-goog-request params to headers for LRO-polling methods
fix: remove extra protos in ESM & capture ESM in headers
docs: update comments for a Nodejs stream object
PiperOrigin-RevId: 721038181
Source-Link: googleapis/googleapis@331a41a
Source-Link: https://github.com/googleapis/googleapis-gen/commit/e81b4c5b5208895f663a24048615a59d5636f415
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJlODFiNGM1YjUyMDg4OTVmNjYzYTI0MDQ4NjE1YTU5ZDU2MzZmNDE1In0=
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [backupdr] add InitializeServiceAPI
feat: Update field behavior of
networksfield in messageManagementServertoOPTIONALfeat: add enum to Backup Vault Access Restriction field
feat:
ignore_backup_plan_referencesadded to the DeleteBackupVaultRequestfix!: Update field behavior of
resource_typefield in messageBackupPlanAssociationtoREQUIREDdocs: A comment for field
networksin message.google.cloud.backupdr.v1.ManagementServeris changeddocs: A comment for field
requested_cancellationin message.google.cloud.backupdr.v1.OperationMetadatais changeddocs: A comment for field
resource_typein message.google.cloud.backupdr.v1.BackupPlanis changeddocs: A comment for field
backup_retention_daysin message.google.cloud.backupdr.v1.BackupRuleis changeddocs: A comment for field
resource_typein message.google.cloud.backupdr.v1.BackupPlanAssociationis changeddocs: A comment for field
data_sourcein message.google.cloud.backupdr.v1.BackupPlanAssociationis changeddocs: A comment for field
rule_idin message.google.cloud.backupdr.v1.RuleConfigInfois changeddocs: A comment for field
last_backup_errorin message.google.cloud.backupdr.v1.RuleConfigInfois changeddocs: A comment for enum value
ACCESS_RESTRICTION_UNSPECIFIEDin enumAccessRestrictionis changeddocs: A comment for field
uidin message.google.cloud.backupdr.v1.BackupVaultis changeddocs: A comment for field
access_restrictionin message.google.cloud.backupdr.v1.BackupVaultis changedPiperOrigin-RevId: 713528070
Source-Link: googleapis/googleapis@8cd8706
Source-Link: https://github.com/googleapis/googleapis-gen/commit/a5c65facebe8d5523ade60fa5506bc8c35dad868
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJhNWM2NWZhY2ViZThkNTUyM2FkZTYwZmE1NTA2YmM4YzM1ZGFkODY4In0=
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: [backupdr] remove redundant gRPC service config file
feat: specify retry configuration
PiperOrigin-RevId: 712493958
Source-Link: googleapis/googleapis@29aea41
Source-Link: https://github.com/googleapis/googleapis-gen/commit/04bcbab4505989e984b1403d438fffc0312144af
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiIwNGJjYmFiNDUwNTk4OWU5ODRiMTQwM2Q0MzhmZmZjMDMxMjE0NGFmIn0=
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix!: [backupdr] Remove visibility of unneeded TestIamPermissions RPC
fix!: Remove visibility of unneeded InitiateBackup RPC
fix!: Remove visibility of unneeded AbandonBackup RPC
fix!: Remove visibility of unneeded FinalizeBackup RPC
fix!: Remove visibility of unneeded RemoveDataSource RPC
fix!: Remove visibility of unneeded SetInternalStatus RPC
PiperOrigin-RevId: 683196317
Source-Link: googleapis/googleapis@c532f35
Source-Link: https://github.com/googleapis/googleapis-gen/commit/fd43f5733b002358fa679623f6099aafb6660c8e
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJmZDQzZjU3MzNiMDAyMzU4ZmE2Nzk2MjNmNjA5OWFhZmI2NjYwYzhlIn0=
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [backupdr] Client library for the backupvault api is added
feat: Add backupplan proto
feat: Add backupplanassociation proto
feat: Add backupvault_ba proto
feat: Add backupvault_gce proto
docs: A comment for field
oauth2_client_idin message.google.cloud.backupdr.v1.ManagementServeris changeddocs: A comment for field
parentin message.google.cloud.backupdr.v1.ListManagementServersRequestis changeddocs: A comment for field
management_serversin message.google.cloud.backupdr.v1.ListManagementServersResponseis changeddocs: A comment for field
namein message.google.cloud.backupdr.v1.GetManagementServerRequestis changeddocs: A comment for field
parentin message.google.cloud.backupdr.v1.CreateManagementServerRequestis changeddocs: A comment for field
requested_cancellationin message.google.cloud.backupdr.v1.OperationMetadatais changedPiperOrigin-RevId: 678800741
Source-Link: googleapis/googleapis@d36e288
Source-Link: https://github.com/googleapis/googleapis-gen/commit/fba9d225b43dcf7361006491810485cdf1b57cdb
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJmYmE5ZDIyNWI0M2RjZjczNjEwMDY0OTE4MTA0ODVjZGYxYjU3Y2RiIn0=
END_NESTED_COMMIT