Skip to content

Use version.py instead of pkg_resource #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joinsion opened this issue Dec 9, 2021 · 0 comments · Fixed by #1623
Closed

Use version.py instead of pkg_resource #1622

joinsion opened this issue Dec 9, 2021 · 0 comments · Fixed by #1623
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@joinsion
Copy link
Contributor

joinsion commented Dec 9, 2021

I met the same issue on the google-api-python-client about the pkg_resources exception (
googleapis/python-api-core#27)

google-api-python-client/googleapiclient/model.py

Line 34 in 0f2e2a1

_LIBRARY_VERSION = pkg_resources.get_distribution("google-api-python-client").version 

pkg_resources.DistributionNotFound: The 'google-api-python-client' distribution was not found and is required by the application

I found the google-auth source and python-api-core has changed. Could it be changed this way accordingly?
googleapis/google-auth-library-python@ff6b52c
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Dec 9, 2021
@joinsion joinsion mentioned this issue Dec 10, 2021
Merged
@parthea parthea added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Dec 11, 2021
@kyohei3 kyohei3 mentioned this issue Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expose library version at googleapiclient.__version__ joinsion/google-api-python-client
3 participants
@parthea @joinsion @yoshi-automation