Skip to content

Commit 4517317

Browse files
committed
Minor refactoring of the variable names
[email protected] Review URL: https://codereview.chromium.org/1544473002 .
1 parent 9ab88de commit 4517317

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

tests/test_http.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -634,23 +634,23 @@ def test_retry_ssl_errors_non_resumable(self):
634634
self.assertEqual({u'foo': u'bar'}, response)
635635

636636
def test_retry_ssl_errors_resumable(self):
637-
f = open(datafile('small.png'), 'rb')
638-
fd = BytesIO(f.read())
639-
upload = MediaIoBaseUpload(
640-
fd=fd, mimetype='image/png', chunksize=500, resumable=True)
641-
model = JsonModel()
642-
643-
request = HttpRequest(
644-
HttpMockWithSSLErrors(
645-
3, {'status': '200', 'location': 'location'}, '{"foo": "bar"}'),
646-
model.response,
647-
u'https://www.example.com/file_upload',
648-
method='POST',
649-
resumable=upload)
650-
request._sleep = lambda _x: 0 # do nothing
651-
request._rand = lambda: 10
652-
response = request.execute(num_retries=3)
653-
self.assertEqual({u'foo': u'bar'}, response)
637+
with open(datafile('small.png'), 'rb') as small_png_file:
638+
small_png_file_descriptor = BytesIO(small_png_file.read())
639+
upload = MediaIoBaseUpload(fd=small_png_file, mimetype='image/png',
640+
chunksize=500, resumable=True)
641+
model = JsonModel()
642+
643+
request = HttpRequest(
644+
HttpMockWithSSLErrors(
645+
3, {'status': '200', 'location': 'location'}, '{"foo": "bar"}'),
646+
model.response,
647+
u'https://www.example.com/file_upload',
648+
method='POST',
649+
resumable=upload)
650+
request._sleep = lambda _x: 0 # do nothing
651+
request._rand = lambda: 10
652+
response = request.execute(num_retries=3)
653+
self.assertEqual({u'foo': u'bar'}, response)
654654

655655
def test_retry(self):
656656
num_retries = 5

0 commit comments

Comments
 (0)