@@ -258,17 +258,20 @@ class {{service.name}}RestTransport(_Base{{ service.name }}RestTransport):
258
258
resp = self._interceptor.post_{{ method.name|snake_case }}(resp)
259
259
response_metadata = [(k, str(v)) for k, v in response.headers.items()]
260
260
resp, _ = self._interceptor.post_{{ method.name|snake_case }}_with_metadata(resp, response_metadata)
261
- {# TODO(https://github.com/googleapis/gapic-generator-python/issues/2279): Add logging support for rest streaming. #}
262
- {% if not method .server_streaming %}
263
261
if CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor(logging.DEBUG): # pragma: NO COVER
262
+ {# Logging of response iterator is in google-api-core #}
263
+ {% if not method .server_streaming %}
264
264
try:
265
265
response_payload = {% if method .output .ident .is_proto_plus_type %} {{ method.output.ident }}.to_json(response){% else %} json_format.MessageToJson(resp){% endif %}
266
266
267
267
except:
268
268
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2283): Remove try/except once unit tests are updated. #}
269
269
response_payload = None
270
+ {% endif %} {# if not method.server_streaming #}
270
271
http_response = {
272
+ {% if not method .server_streaming %}
271
273
"payload": response_payload,
274
+ {% endif %} {# if not method.server_streaming #}
272
275
"headers": dict(response.headers),
273
276
"status": response.status_code,
274
277
}
@@ -282,7 +285,6 @@ class {{service.name}}RestTransport(_Base{{ service.name }}RestTransport):
282
285
"httpResponse": http_response,
283
286
},
284
287
)
285
- {% endif %} {# if not method.server_streaming #}
286
288
return resp
287
289
288
290
{% endif %} {# method.void #}
0 commit comments