Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Decouple Regression Model validation from building a regression model #1593

Open
hnpl opened this issue Sep 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@hnpl
Copy link
Contributor

hnpl commented Sep 5, 2024

What's hard to do? (limit 100 words)

Currently, we do k-fold validation every time we call the constructor [1] of RegressionEstimator. The k-fold validation is private within the class. However, there's a need for using the validator without using the model [2], which calls the EstimatorModel to do k-fold validation. This is confusing.

[1]

self._k_fold_cross_validation(
self.raw_data_points,
num_cross_validation_folds,
max_data_point_error,
max_fold_geomean_error,
)

[2]
# Validate model
delay_model.DelayModel(model)

Current best alternative workaround (limit 100 words)

N/A

Your view of the "best case XLS enhancement" (limit 100 words)

Decouple RegressionEstimator validation from constructor, allowing validation without using the model.

@hnpl hnpl added the enhancement New feature or request label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant