From 85eafa37a986ca53822c30438b622d41b4ca1922 Mon Sep 17 00:00:00 2001 From: diamondm Date: Fri, 1 Jun 2018 10:57:16 -0700 Subject: [PATCH] Update Truth to Guava 25.1. Includes a workaround for https://github.com/google/compile-testing/issues/149 RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=198895795 --- core/pom.xml | 10 ++++++++-- .../common/truth/ComparableSubjectCompileTest.java | 4 ++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/core/pom.xml b/core/pom.xml index 30e93a9d5..f79cc02f9 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -10,8 +10,8 @@ truth Truth Core - 23.6-android - 23.6-jre + 25.1-android + 25.1-jre 2.8.2 4.12 1.3.0 @@ -31,6 +31,12 @@ checker-compat-qual ${checker-framework.version} + + + org.checkerframework + checker-qual + ${checker-framework.version} + junit junit diff --git a/core/src/test/java/com/google/common/truth/ComparableSubjectCompileTest.java b/core/src/test/java/com/google/common/truth/ComparableSubjectCompileTest.java index 46c0f85b8..767fbd0fd 100644 --- a/core/src/test/java/com/google/common/truth/ComparableSubjectCompileTest.java +++ b/core/src/test/java/com/google/common/truth/ComparableSubjectCompileTest.java @@ -55,6 +55,8 @@ public void comparableMixedTypesDontCompile() { assertAbout(javaSource()) .that(file) + // https://github.com/google/compile-testing/issues/149 + .withCompilerOptions("-sourcepath", "") .failsToCompile() .withErrorContaining("java.lang.String cannot be converted to test.MyTest.ComparableType") .in(file) @@ -84,6 +86,8 @@ public void rawComparableTypeMixedTypes() { "}"); assertAbout(javaSource()) .that(file) + // https://github.com/google/compile-testing/issues/149 + .withCompilerOptions("-sourcepath", "") .failsToCompile() .withErrorContaining( "java.lang.String cannot be converted to test.MyTest.RawComparableType")