You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are two primary questions in regard of the possible implementation:
Ensuring deterministic ordering is tricky, the only feasible way is to sort all keys before the iteration (meaning lexicographical order as in opposite to the insertion one in regular dicts).
Are there any tests for the package? Where should they be put?
The text was updated successfully, but these errors were encountered:
I'm very interested in sorting this out at the moment, at least for message initialisation. @adonovan, would you accept a PR for this? (CLA is on file, and I'm a Xoogler).
Turned out to be fairly easy, map construction is here: #491
It seems like there isn't great test coverage of the lib/proto functionality at the moment. Didn't touch that too much. This code exists in a private fork, too, and has been tested against some fairly complex protos with map fields there.
negz
linked a pull request
Oct 2, 2023
that will
close
this issue
There is a TODO in the codebase, so I assume the support is desired.
https://github.com/google/starlark-go/blob/master/lib/proto/proto.go#L84
There are two primary questions in regard of the possible implementation:
The text was updated successfully, but these errors were encountered: