Summary
XSS may be triggered in AngularJS applications that sanitize user-controlled HTML snippets before passing them to JQLite methods like JQLite.prepend, JQLite.after, JQLite.append, JQLite.replaceWith, JQLite.append, new JQLite and angular.element.
Description
JQLite (DOM manipulation library that's part of AngularJS) manipulates input HTML before inserting it to the DOM in jqLiteBuildFragment.
One of the modifications performed expands an XHTML self-closing tag.
If jqLiteBuildFragment is called (e.g. via new JQLite(aString)) with user-controlled HTML string that was sanitized (e.g. with DOMPurify), the transformation done by JQLite may modify some forms of an inert, sanitized payload into a payload containing JavaScript - and trigger an XSS when the payload is inserted into DOM.
This is similar to a bug in jQuery htmlPrefilter function that was fixed in 3.5.0.
Proof of concept
const inertPayload = `<div><style><style/><img src=x onerror="alert(1337)"/>`
Note that the style element is not closed and <img would be a text node inside the style if inserted into the DOM as-is.
As such, some HTML sanitizers would leave the <img as is without processing it and stripping the onerror attribute.
angular.element(document).append(inertPayload);
This will alert, as <style/> will be replaced with <style></style> before adding it to the DOM, closing the style element early and reactivating img.
Patches
The issue is patched in JQLite bundled with angular 1.8.0. AngularJS users using JQuery should upgrade JQuery to 3.5.0, as a similar vulnerability affects jQuery <3.5.0.
Workarounds
Changing sanitizer configuration not to allow certain tag grouping (e.g. <option><style></option>) or inline style elements may stop certain exploitation vectors, but it's uncertain if all possible exploitation vectors would be covered. Upgrade of AngularJS to 1.8.0 is recommended.
References
GHSA-mhp6-pxh8-r675
GHSA-gxr4-xjj5-5px2
GHSA-jpcq-cgw6-v4j6
https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/
https://snyk.io/vuln/SNYK-JS-ANGULAR-570058
koto Analyst
masatokinugawa Analyst
Summary
XSS may be triggered in AngularJS applications that sanitize user-controlled HTML snippets before passing them to
JQLitemethods likeJQLite.prepend,JQLite.after,JQLite.append,JQLite.replaceWith,JQLite.append,new JQLiteandangular.element.Description
JQLite (DOM manipulation library that's part of AngularJS) manipulates input HTML before inserting it to the DOM in
jqLiteBuildFragment.One of the modifications performed expands an XHTML self-closing tag.
If
jqLiteBuildFragmentis called (e.g. vianew JQLite(aString)) with user-controlled HTML string that was sanitized (e.g. with DOMPurify), the transformation done by JQLite may modify some forms of an inert, sanitized payload into a payload containing JavaScript - and trigger an XSS when the payload is inserted into DOM.This is similar to a bug in jQuery
htmlPrefilterfunction that was fixed in 3.5.0.Proof of concept
Note that the style element is not closed and
<imgwould be a text node inside the style if inserted into the DOM as-is.As such, some HTML sanitizers would leave the
<imgas is without processing it and stripping theonerrorattribute.This will alert, as
<style/>will be replaced with<style></style>before adding it to the DOM, closing the style element early and reactivatingimg.Patches
The issue is patched in
JQLitebundled with angular 1.8.0. AngularJS users using JQuery should upgrade JQuery to 3.5.0, as a similar vulnerability affects jQuery <3.5.0.Workarounds
Changing sanitizer configuration not to allow certain tag grouping (e.g.
<option><style></option>) or inline style elements may stop certain exploitation vectors, but it's uncertain if all possible exploitation vectors would be covered. Upgrade of AngularJS to 1.8.0 is recommended.References
GHSA-mhp6-pxh8-r675
GHSA-gxr4-xjj5-5px2
GHSA-jpcq-cgw6-v4j6
https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/
https://snyk.io/vuln/SNYK-JS-ANGULAR-570058