Skip to content

Commit

Permalink
CI: Migrate to upload-artifact@v4
Browse files Browse the repository at this point in the history
Uploading to the same artifact name with implicit merge is no longer allowed, so merge explicitly.

Initially I thought to not provide the merged artifact, but it seems it's mentioned in instructions several times, so, fine.

PiperOrigin-RevId: 693629641
  • Loading branch information
oprypin authored and copybara-github committed Nov 6, 2024
1 parent 502da7d commit 6433bce
Showing 1 changed file with 16 additions and 5 deletions.
21 changes: 16 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ jobs:
-v "$(pwd):/io" \
"$DOCKER_IMAGE" \
/io/build_scripts/wheels/manylinux.sh
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: dist
path: dist
name: dist-${{ matrix.platform }}-${{ matrix.pyver }}
path: dist/*.whl
macosx_wheels:
name: Python ${{ matrix.python_version }} MacOS wheels
# Note: the container MacOS version may differ from the SDK
Expand All @@ -68,7 +68,18 @@ jobs:
python-version: ${{ matrix.python_version }}
- name: Build MacOS wheels
run: './build_scripts/wheels/macos.sh'
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: dist-macos-py${{ matrix.python_version }}
path: dist/*.whl
merge:
name: Merge artifacts
runs-on: ubuntu-latest
needs:
- manylinux_wheels
- macosx_wheels
steps:
- name: Merge artifacts
uses: actions/upload-artifact/merge@v4
with:
name: dist
path: dist

0 comments on commit 6433bce

Please sign in to comment.