Normalize PyPI package names #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same name as the subsequent set comprehensions so it's clearer to the reader that the same data is being operated on multiple times.
oliverchang
reviewed
Aug 5, 2022
There was a problem hiding this comment.
nice! some comments.
Please also update the test here:
osv.dev/docker/worker/worker_test.py
Line 891 in a4b682a
to make the test data have an un-normalized name.
* Standardize quoting * Abstract ecosystem-specific logic into normalization function See google#578 for details
oliverchang
reviewed
Aug 5, 2022
This will allow for the normalized value to be stored in Datastore and also set in the pubsub message.
This way the package name gets normalized before it goes to Datastore and PubSub
|
By George, I do believe I have tests. PTAL |
|
Very nice! I think you just need to format your code per https://github.com/google/osv.dev/runs/7782343232?check_suite_focus=true. (Ignore the lint errors -- this wasn't blocking our check and we need to fix them per #521) |
|
My bad, I knew I'd introduced changes that needed that and forgot to run it. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #508