Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support local database for guided remediation #1295

Open
oliverchang opened this issue Oct 4, 2024 · 1 comment
Open

Support local database for guided remediation #1295

oliverchang opened this issue Oct 4, 2024 · 1 comment
Assignees
@michaelkedar
Labels
guided remediation Related to guided remediation / osv-scanner fix

Comments

@oliverchang
Copy link
Collaborator

oliverchang commented Oct 4, 2024 •
edited
Loading

i.e. respect https://google.github.io/osv-scanner/experimental/offline-mode/ for scanning.
@oliverchang oliverchang added the guided remediation Related to guided remediation / osv-scanner fix label Oct 4, 2024
@michaelkedar michaelkedar mentioned this issue Oct 8, 2024
Merged
michaelkedar added a commit that referenced this issue Oct 15, 2024
@michaelkedar
feat(guided remediation): support offline database in fix subcommand (#…
cbe2f70 
…1306)

#1295
Support the `--experimental-offline` and
`--experimental-download-offline-databases` flags in `osv-scanner fix`.

This is pretty inefficient since `local.MakeRequest()` reads and parses
the zip file every time it's called. I didn't want to make too many
changes to make it more efficient since we'll probably end up
refactoring it in v2.

Also fixed the links to headings on the offline docs page.
@another-rex
Copy link
Collaborator

Is this resolved with #1306?

@BrewTestBot BrewTestBot mentioned this issue Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelkedar michaelkedar

Labels
guided remediation Related to guided remediation / osv-scanner fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliverchang @michaelkedar @another-rex